andi34 / photobooth

A Photobooth web interface for Linux and Windows.
MIT License
72 stars 39 forks source link

Improve Nginx settings #477

Closed kreativmonkey closed 2 years ago

kreativmonkey commented 2 years ago

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

After some testing i recommand to switch the default webserver to nginx becouse of the performance and flexibility.

andi34 commented 2 years ago

Hey and thanks for your PR! To switch by default, we would need to detect the PHP Version as e.g. Ubuntu 22.04 uses PHP8(.1?) by default which will fail with the config for 7.4. Any Idea how to Deal with this? Lighttpd also only checks for 7.3 and 7.4 ...

kreativmonkey commented 2 years ago

That is why i explicitly use php7.4-fpm to install and activation. you can do that because this versions are currently supported. You don't need to use the newest versions in the repository ;-)