search

andialbrecht / crunchyfrog

Head over to RunSQLRun, the successor of CrunchyFrog
http://runsqlrun.org
GNU General Public License v3.0
4 stars 2 forks source link

Issue with license #75

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hello,

I am trying to package crunchyfrog for fedora:
https://bugzilla.redhat.com/show_bug.cgi?id=526451

And there have been issues with license. Home page says everything is under
GNU General Public License v3, but on visting code it seems that is not the
case. May these references be updated in case they are part of some cruft
which was supposed to be updated or removed.

[-] MUST: The License field in the package spec file must match the actual
license. [3]
Mostly, but not all.
utils/msgfmt.py written by another author Martin v. L.wis and license is
unknown. I think we can't distribute it (and usual it is part of python-tools).
In utils directory also present other files with different authors, some have
Free licenses and we can distribute them, like utils/builder/docbook.py:
:Author: Ollie Rutherfurd
:Revision: $Revision$
:Date: $Date$
:Copyright: This module has been placed in the public domain.
but some other license is unknown, there are: utils/builder/dbbuilder.py,
utils/builder/gcwiki.py, utils/command/* as I undartand is part of sphinx by
Sebastian Wiesner and Licensed under MIT.

extras/plugins/sqlformat/sqlformat/printsql.py Authors Peter Bengtsson, Andi
Albrecht also without license mention.
cf/sqlparse/dialects.py have header:
# This module is part of python-sqlparse and is released under
# the BSD License: http://www.opensource.org/licenses/bsd-license.php.

I think there all files must be completely revisited...

It would be great if these concerns are met as soon as possible. It will
speed up review process.

Thanks,

Original issue reported on code.google.com by rakesh.p...@gmail.com on 9 Nov 2009 at 11:23

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 9 Nov 2009 at 11:35

GoogleCodeExporter commented 9 years ago 
Thanks for pointing at these issues!

* extras/plugins/sqlformat is now removed (r9775159ef6d8), this plugin has been 
replaced by sqlparse.

* cf/sqlparse is an external Python module licensed under BSD. If it's 
installed as a 
dependency cf/sqlparse can safely be removed without any changes. The sqlparse 
Python 
module is available here: http://python-sqlparse.googlecode.com

* msgfmt.py is part of Python 
http://svn.python.org/view/python/trunk/Tools/i18n/msgfmt.py?view=markup I'm 
not sure 
what to do here, it's bundled with a lot of applications and it's required 
during 
setup to build the *.mo files

* utils/builder/gcwiki.py is written by me and part of the project.

* utils/builder/dbbuilder.py and utils/builder/docbook.py are obsolete and 
removed 
(rc3f856f24e3a, r783150b85390).

* utils/command/sphinx_build.py was copied from Sphinx for backwards 
compatibility. 
Since Sphinx > 0.5 should be available on most systems it's not required 
anymore 
(removed in r966f01c93ea9).

Please let me know if there are any other issue or if the license problems are 
solved 
with this changes :)

Andi

Original comment by albrecht.andi on 9 Nov 2009 at 7:39

GoogleCodeExporter commented 9 years ago 
BTW, there are two more third-party modules included. cf/thirdparty contains 
ooolib 
released under GPLv2. And cf/shell contains ipython_view.py relaesed under BSD.

Original comment by albrecht.andi on 9 Nov 2009 at 7:44

GoogleCodeExporter commented 9 years ago 
Thanks for very quick response. I will review again and check with guidelines 
and report.

Happy hacking :)

Original comment by rakesh.p...@gmail.com on 10 Nov 2009 at 6:07

GoogleCodeExporter commented 9 years ago 
Is there any progress?

Original comment by hubbi...@gmail.com on 24 Aug 2010 at 10:24

GoogleCodeExporter commented 9 years ago 
Any feedback is welcome! I really want to have this resolved for the next 
release :)

Original comment by albrecht.andi on 24 Aug 2010 at 10:28

GoogleCodeExporter commented 9 years ago 
I want help, but only you can known license of used components.

Original comment by hubbi...@gmail.com on 24 Aug 2010 at 11:53

GoogleCodeExporter commented 9 years ago 
Comments #2 and #3 list all components used by CrunchyFrog so far. I'd prefer 
to keep them, but I'd remove/replace them if they're causing troubles for 
package maintainers.

Original comment by albrecht.andi on 24 Aug 2010 at 11:56

GoogleCodeExporter commented 9 years ago 
msgfmt.py can be used external in system where python installed?

ooolib and shell libraries are required? Are you think it permitted ship this 
libraries with GPLv3 licensed code?

Original comment by hubbi...@gmail.com on 24 Aug 2010 at 12:11

GoogleCodeExporter commented 9 years ago 
I'm really not sure about it and I'm far from being a licensing expert :) For 
me it's fine to ship those libraries bundled with this application. At least 
for msgfmt.py I've seen some projects shipping it bundled too.

Original comment by albrecht.andi on 24 Aug 2010 at 12:17

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 26 Oct 2010 at 12:32

GoogleCodeExporter commented 9 years ago 
I've pushed a bunch of revisions that should make things clearer regarding 
licensing issues:

* sqlparse is now removed from the source tree and declared as external 
dependency (revision 31b22aa245). A Ubuntu package is currently available from 
the PPA for this project. The sources for sqlparse are available here: 
http://python-sqlparse.googlecode.com

* ooolib is now removed from the source tree and declared as an optional 
dependency (revision 5c2d233f75 and revision 8a5b45c3dd).

Now everything in the source tree is part of the project except

* utils/msgfmt.py which is written by Martin von Löwis and distributed as part 
of the Python distribution.
* cf/shell/ipython_view.py is a BSD-licensed snippet as found as an example on 
the Ipython project page.

Both are mentioned in the AUTHORS file.

Please let me know if there are still licensing issues and thanks a lot for the 
feedback!

Original comment by albrecht.andi on 15 Nov 2010 at 5:37

GoogleCodeExporter commented 9 years ago 
Albrecht, thank you very much for the work! I think now we can continue.

Original comment by pahanhub...@gmail.com on 18 Nov 2010 at 12:58