Open living180 opened 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.01
:tada:
Comparison is base (
fc76056
) 96.95% compared to head (d2ab15c
) 96.97%.:exclamation: Current head d2ab15c differs from pull request most recent head ff4f391. Consider uploading reports for the commit ff4f391 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This is just the fix I need. Ran into some problems with parsing SQL with ~50k ID IN
clauses, which with 0.4.4
takes a bit over 6 minutes to parse and with this patch only takes 6 seconds !!!
any progress here?
This PR supersedes #623. The meat of the PR is the same: fix the remaining portion of issue #621 by making
TokenList.value
a dynamically-computed property rather than an attribute. This avoids the quadratic runtime behavior that occurred due to recomputingTokenList.value
each timeTokenList.group_tokens(
) was called withextend=True
.The previous PR #623 had some rather awkward hacks related to stripping comments, but I found that I could avoid those by simply tweaking the comment stripping process to strip comments from a token list before stripping any sublists, making this PR much simpler.