andialbrecht / sqlparse

A non-validating SQL parser module for Python
BSD 3-Clause "New" or "Revised" License
3.71k stars 693 forks source link

Ensure nested ordered identifiers are grouped (fixes #745) #746

Closed john-bodley closed 7 months ago

john-bodley commented 11 months ago

Fixes https://github.com/andialbrecht/sqlparse/issues/745.

Thanks for contributing!

Before submitting your pull request please have a look at the following checklist:

In addition, please take care to provide a proper description on what your change does, fixes or achieves when submitting the pull request.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f101546) 96.97% compared to head (d43fb9c) 96.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #746 +/- ## ======================================= Coverage 96.97% 96.98% ======================================= Files 20 20 Lines 1556 1557 +1 ======================================= + Hits 1509 1510 +1 Misses 47 47 ``` | [Files](https://app.codecov.io/gh/andialbrecht/sqlparse/pull/746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andi+Albrecht) | Coverage Δ | | |---|---|---| | [sqlparse/engine/grouping.py](https://app.codecov.io/gh/andialbrecht/sqlparse/pull/746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andi+Albrecht#diff-c3FscGFyc2UvZW5naW5lL2dyb3VwaW5nLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andialbrecht commented 7 months ago

Ah, cool! Thanks for finding this!