search

andig / carddav2fb

Download CardDAV VCards and upload as phonebook to AVM FRITZ!Box
63 stars 19 forks source link

Use sabre for vcard parsing #145

Closed blacksenator closed 5 years ago

blacksenator commented 5 years ago

complete conversion so that sabre/vobject fits

Replaces #130, fixes #128.

andig commented 5 years ago

Unfortunately the PR has conflicts. Would it be possible to rebase onto current master? Do this by pulling master onto master, switch to this branch and run git rebase master.

Be sure to create a copy of your branch (by branching again) before doing this in case anything goes wrong.

andig commented 5 years ago

Kein Rebase- die Konflikte sind weiter da. Master vorher lokal aktualisiert?

andig commented 5 years ago

Looks like more problems with object typehints?

andig commented 5 years ago

Der cs fixer bemängelt noch eine Leerzeile die gem. Styleguide nicht da sein sollte: https://travis-ci.org/andig/carddav2fb/jobs/570347198#L603

blacksenator commented 5 years ago

Der cs fixer bemängelt noch eine Leerzeile die gem. Styleguide nicht da sein sollte: https://travis-ci.org/andig/carddav2fb/jobs/570347198#L603

Ja, ich weiß - aber ich finde sie um´s verrecken nicht! Any suggestions?

andig commented 5 years ago

Great job!!! See #150 to continue the discussion.