andig / carddav2fb

Download CardDAV VCards and upload as phonebook to AVM FRITZ!Box
63 stars 19 forks source link

Allow URI as data for vcard PHOTO #170

Closed SpamReceiver closed 5 years ago

SpamReceiver commented 5 years ago

Nextcloud has implemented a change to allow URI as data for VCards: https://github.com/nextcloud/server/pull/13117 Consequently, I find in my database a number of VCFs 3.0 with: BEGIN:VCARD VERSION:3.0 PRODID:-//Sabre//Sabre VObject 4.1.6//EN UID:C7821D49-BED0-0001-7F2A-E8507C67107F.vcf FN:xxxx ORG:xxxx PHOTO;VALUE=URI:DATA:IMAGE/JPEG;BASE64\,/9j/4QAYRXhpZgAASUkqAAgAAAAAAAAAAAA

These photos are not recognized by carddav2fb und thus missing from the uploaded phonebook.

andig commented 5 years ago

/cc @blacksenator - is that something you would like to look into?

blacksenator commented 5 years ago

Okay

@SpamReceiver - according to this RFC 2426 specification:

Type encoding: The encoding MUST be reset to "b" using the ENCODING parameter in order to specify inline, encoded binary data. If the value is referenced by a URI value, then the default encoding of 8bit is used and no explicit ENCODING parameter is needed. Type value: A single value. The default is binary value. It can also be reset to uri value. The uri value can be used to specify a value outside of this MIME entity

It would be extremly helpfull, if you can send me a few of your VCFs (anonymized but with original imagadata!) for test purposes.