Closed blacksenator closed 4 years ago
/cc @SpamReceiver could you test this?
/cc @SpamReceiver could you test this?
Yes, I would like to, but how do I access the changed files? I'm quite unfamilar with GIT...
See https://stackoverflow.com/questions/27567846/how-can-i-check-out-a-github-pull-request-with-git#30584951 for hints how to do this.
Tested successfully: git pull origin pull/172/head [OK]
./carddav2fb download -i test.txt --> Downloaded 294 vCard(s) [OK]
./carddav2fb convert -i test.txt convert.txt --> Uploaded/refreshed 56 of 83 image file(s) --> Converted 294 vCard(s) [OK]
./carddav2fb upload convert.txt --> Successful uploaded new FRITZ!Box phonebook [OK]
Checked http://fritz.box phone book: photos are attached to contacts [OK] Checked FritzFon C5: photos are attached to contacts [OK] Checked Android FritzFon app: Photos are attached to contacts [OK]
./carddav2fb run -i --> Downloaded 294 vCard(s) --> Uploaded/refreshed 0 of 83 image file(s) --> Converted 294 vCard(s) --> Successful uploaded new FRITZ!Box phonebook [OK]
One possibly unrelated thing I have noticed.
When I run carddav2fb -i run
, the following message appears:
Detaching and uploading image(s)
294/294 [============================] 100%PHP Warning: ftp_close(): SSL_read on shutdown: Connection reset by peer (104) in /mnt/data/var/carddav2fb/src/functions.php on line 289
294/294 [============================] 100%
That's an independent issue also noticed in #167.
Are you saying this didn't happen with previous versions?
I seldomly call the script from the command line, so I can't tell if the ftp_close() warning was happening earlier. It was happening prior to this fix #172, though. I saw it when I was analysing why my photos didn't show up on the FritzFon.
Fix #170