search

andig / carddav2fb

Download CardDAV VCards and upload as phonebook to AVM FRITZ!Box
63 stars 19 forks source link

Send Content-Type with xml request. #167 #187

Closed develth closed 4 years ago

develth commented 4 years ago

Fixes a HTTP 400 when Server wants the regarding Content-Type, too. Fixes https://github.com/andig/carddav2fb/issues/167.

andig commented 4 years ago

Are there any other requests where we would need to add the xml header?

develth commented 4 years ago

Nothing found until yet

andig commented 4 years ago

See https://travis-ci.org/andig/carddav2fb/jobs/634625477#L343, the indents are wrong.

develth commented 4 years ago

What should be 'correct'? Are you follow psr-2?

andig commented 4 years ago

We're using php-cs-fixer on travis:

./vendor/bin/php-cs-fixer fix --config=.php_cs.php -v --dry-run --diff --stop-on-violation