search

andig / carddav2fb

Download CardDAV VCards and upload as phonebook to AVM FRITZ!Box
63 stars 19 forks source link

convert command error fixing #207

Closed blacksenator closed 4 years ago

blacksenator commented 4 years ago

Necessary adjustment in VcardFile.php, to take into account the changes from #205 in the Backend.php constructor Fix #206

andig commented 4 years ago

That's not a very good fix. Please revist https://github.com/andig/carddav2fb/pull/205/files#diff-6e410467432f64dd57dcdb8c46a8b0f8R65. Why is the first parameter (url) optional and the second (method) is not? If they're not needed then both should be optional.

blacksenator commented 4 years ago

You´re right. I didn't pay attention to the order of the optional parameters

blacksenator commented 4 years ago

is the correction so far okay for you now?