search

andig / carddav2fb

Download CardDAV VCards and upload as phonebook to AVM FRITZ!Box
63 stars 19 forks source link

code improvement #209

Closed blacksenator closed 4 years ago

blacksenator commented 4 years ago

fixing #208

andig commented 4 years ago

Was genau tut dieser PR i.S. von "code improvement"? Ich hab die Erklärung leider nicht nicht verstanden?

andig commented 4 years ago

It would be helpful to split this PR into multiple functions for review, i.e. one commit for „move fritzbox login to function“ and more. That should help to understand the scope of each commit.