search

andig / carddav2fb

Download CardDAV VCards and upload as phonebook to AVM FRITZ!Box
63 stars 19 forks source link

Ignore duplicates #225

Open LaCruz75 opened 3 years ago

LaCruz75 commented 3 years ago

I using carddav2fb with two carddav-users to generate a family phone book. Some contacts a similar, 'caus we ar knowing same persons.

It is possible to check for duplicate entrys?

Maybe helpfull: https://github.com/carlos22/carddav2fb/issues/23

blacksenator commented 3 years ago

@LaCruz75: As far as I can see, carlos22 did not implement the suggested change, but referred to duplicate merging in the source data.

Recommendation: I myself and my wife have a comparable starting position. In addition to individual iCloud accounts, we use another shared account with the contacts that affect us both. This is also easy to maintain with CardBook for Thunderbird, for example.

Regardless of this: The referenced diff only uses a simple comparison of the name as an indicator. This is certainly not difficult to implement, but is it really the (only) requirement? What are duplicates? Same name AND same phone number? Just the same name? Only the same number? Or ...?

pucicu commented 2 years ago

I strongly support this feature request. Would it be possible to add such a duplicate test (comparing name and phone number)?

blacksenator commented 2 years ago

@andig: If you have an idea for a general solution approach, I can try to realize a PR