andig / carddav2fb

Download CardDAV VCards and upload as phonebook to AVM FRITZ!Box
63 stars 19 forks source link

+49 replacement in config example #242

Closed jsjsjsjs closed 2 years ago

jsjsjsjs commented 2 years ago

In 'config.example.php' line 105 '+49' is replaced by empty string. To make this work correct it should be replaced by '0', not an empty string.

One could skip this replacement anyway as dialing is working fine with the number starting with '+49'

blacksenator commented 2 years ago

@jsjsjsjs Thank you very much for your hint. config.example.php shows examples of a configuration. So you can enter whatever is suitable for you there. The example mentioned may not be suitable for you - but certainly for other users. What is really an error is the notice: "conversions are processed consecutively. Order decides!" correctly it should read: "conversions are processed length descending!" So the longest strings on the left are processed before the shorter ones. I will correct that.