andig / fritzapi

Home automation API for Fritz!Box, Fritz!DECT and FRITZ!Powerline devices
MIT License
139 stars 27 forks source link

Fritz!OS 7 - getGuestWlan and setGuestWlan #10

Open grinsekatze003 opened 5 years ago

grinsekatze003 commented 5 years ago

getGuestWlan and setGuestWlan aren't working with Fritz!OS 7 anymore. Any plans to update that function?

andig commented 5 years ago

Could you be more specific what it not working? Any error messages?

IngmarStein commented 5 years ago

I assume these log entries from homebridge-fritz may be related:

[10/8/2018, 9:18:26 PM] [My FritzBox] Updating guest WLAN
[10/8/2018, 9:18:26 PM] [My FritzBox] Getting guest WLAN state
[10/8/2018, 9:18:26 PM] [My FritzBox] 500: Internal Server Error
IngmarStein commented 5 years ago

Sorry, I just notice that homebridge-fritz uses the tr64 API while fritzapi only uses screen scraping. Both approaches seem broken with Fritz!OS 7. The URL seems to have changed from /wlan/guest_access.lua?0=0 to /?sid=<sid>&lp=wGuest, so the current version just ends up at the login page.

andig commented 5 years ago

Thanks for the investigation. I'm a bit short on time and would appreciate a PR if you want or will look into this later.

IngmarStein commented 5 years ago

Sure, here you go: https://github.com/andig/homebridge-fritz/pull/51 I haven't looked into whether the scraper could also be updated. The new page looks quite dynamic.

masipulami commented 5 years ago

Hi,

any news on this issue? Or at least a plan to fix it for FritzOs7?

Thanks in advance for your feedback.

grinsekatze003 commented 5 years ago

Any news on this?

IngmarStein commented 5 years ago

It was an error in Fritz!OS (see https://github.com/andig/homebridge-fritz/pull/51). I think it has been fixed in the current beta (aka Labor).

andig commented 4 years ago

ping @grinsekatze003 could you check if your issue is resolved with current Fritz!OS?