search

andig / homebridge-fritz

Homebridge platform for Fritz!Box router and supported DECT devices
MIT License
74 stars 22 forks source link

Request for support of config-ui-x setup options #108

Open tooh opened 4 years ago

tooh commented 4 years ago

https://github.com/oznu/homebridge-config-ui-x/wiki/Developers:-Plugin-Settings-GUI

andig commented 4 years ago

Feel free to submit a PR

tooh commented 4 years ago

@andig I'm prepared to give it a try. No experience with PR's, so I will need a bit of guidance.

Will start with forking your repo and take it from there.

tooh commented 4 years ago

Please review my PR

andig commented 4 years ago

Please review my PR

I don't see any PR?

jngmrks commented 4 years ago

Ich habs dir rausgesucht: https://github.com/tooh/homebridge-fritz/pull/1/commits/fb75ef73678488b7a4eb0055d066d5c25416e25e

andig commented 4 years ago

Da ich es nicht nutze bräuchte es tester und dann einen PR der hier gemerged werden kann ;)

tooh commented 4 years ago

@oznu I'm willing to try to get this done, can you give some assistance ?

TIA

oznu commented 4 years ago

Sure thing, at a glace the devices structure will be challenging as custom "keys" don't work with the automated form generation as per this.

      "devices": {
        "wifi": {
          "name": "Guest WLAN",
          "display": true
        },
        "outlet-1": {
          "TemperatureSensor": false
        },
        "repeater-1": {
          "TemperatureSensor": false
        },
        "thermostat-2": {
          "ContactSensor": false
        },
        "hidden-3": {
          "display": false
        }
      }
jngmrks commented 4 years ago

@oznu This is not required; hiding or disabling is optional

tooh commented 4 years ago

@jngmrks @oznu Can you assist in moving this forward?

TIA