search

andig / homebridge-fritz

Homebridge platform for Fritz!Box router and supported DECT devices
MIT License
74 stars 22 forks source link

Platform has to be "platform": "FRITZ!Box" since 0.9.5 #124

Open andig opened 4 years ago

andig commented 4 years ago

Due to #120 the config.json needs to be updated as of 0.9.5. Platform has to be (notice upper case):

"platform": "FRITZ!Box"
glowfishDE commented 4 years ago

In addition to the above:

To make it more clear - the word "Fritz!Box" needs to be upper case like this:

CORRECT: "platform": "FRITZ!Box" WRONG: "platform": "Fritz!Box"

This was really ugly to discover since you dont expect your old config to suddenly not work anymore.

andig commented 4 years ago

I can only say one thing. I‘m doing this free of charge in my spare time. If anybody wants to contribute or sponsor this work he is entirely welcome to do any of.

glowfishDE commented 4 years ago

I can only say one thing. I‘m doing this free of charge in my spare time. If anybody wants to contribute or sponsor this work he is entirely welcome to do any of.

If you welcome any sort of help your comment makes no sense, because that is exactly what i did - contributing my knowledge since your comment above was not describing the situation correctly.

Instead of saying "thanks for the additional description" your comment and "eyes emoji" seems rather rude and uncooperative.

But hey - your project.. your bugs.. next time i´ll keep my knowledge for myself instead of sharing it. I dont want to offend the sensible underpaid and really busy developer, right ?

PS: We, as your users, also test and document your software in our spare time - free of charge!

andig commented 4 years ago

Once the damage was done in #120 the only solution was to either document it or revert it (https://github.com/andig/homebridge-fritz/issues/121#issuecomment-619898982). As reverting didn't get any comments and would have been further trouble for users who had updated I decided to leave it as is. Any type of constructive comment on that decision is welcome and we could still go back.

This is open source. I like it to be useful for myself and others. And I'd like to see it grow by contributions and attract wider audience.

But hey - your project.. your bugs.. next time i´ll keep my knowledge for myself instead of sharing it. I dont want to offend the sensible underpaid and really busy developer, right ?

Is that how you feel? I sense sarcasm and don't see place for that here.

glowfishDE commented 4 years ago

Once the damage was done in #120 the only solution was to either document it or revert it (#121 (comment)). As reverting didn't get any comments and would have been further trouble for users who had updated I decided to leave it as is. Any type of constructive comment on that decision is welcome and we could still go back.

This is open source. I like it to be useful for myself and others. And I'd like to see it grow by contributions and attract wider audience.

But hey - your project.. your bugs.. next time i´ll keep my knowledge for myself instead of sharing it. I dont want to offend the sensible underpaid and really busy developer, right ?

Is that how you feel? I sense sarcasm and don't see place for that here.

I am with you on all other points you´ve said. Thats why we are all here for. To contribute and help the developer and the community to improve and debug a software. We all know, that there is alot of effort, time and love in each project.

To answer your question: Yes, i feel like that when i write a comment (about some circumstances i found out) to help others and get a "rolling eyes emoji" and a sulky comment from the developer in exchange instead :-(

Lets not start a discussion though. But be asured, it was not my intend to offend or rant about the quality of your work. I just said, that it was giving me some hard time to find that out. And since you wrote that people have to write "platform" instead "Platform" and i ran into the problem, that also the Word "Fritz" needs to be upper-case i thought this information might be valuable for all of you who are reading this. I didnt want to say that you are doing a bad work or something. So i didnt understand that "beleidigte Leberwurscht" comment of yours.

But anyhow. I think its all said, the bug is solved, people can read the solution here and in advance have some little entertainment about this thread too. So no harm done i guess.

Have a nice day and thanks anyhow for all you do by providing that piece of software. It is indeed cherished and my way to contribute is to write additional information i found useful for myself and maybe others too.

All the best :)

user858753257 commented 4 years ago

when I look at my HOOBS config it is after update to 0.9.5 so :

"interval": 60, "name": "Fritzbox 7590", "concurrent": true, "platform": "Fritz!Box"

in the log I see following :

4.5.2020, 11:28:45 The requested platform "Fritz!Box" was not registered by any plugin. 4.5.2020, 11:28:45 Your config.json is requesting the platform "Fritz!Box" which has not been published by any installed plugins.

andig commented 4 years ago

@F3000 your platform name is wrong. You need CAPTIAL case.

glowfishDE commented 4 years ago

when I look at my HOOBS config it is after update to 0.9.5 so :

"interval": 60, "name": "Fritzbox 7590", "concurrent": true, "platform": "Fritz!Box"

in the log I see following :

4.5.2020, 11:28:45 The requested platform "Fritz!Box" was not registered by any plugin. 4.5.2020, 11:28:45 Your config.json is requesting the platform "Fritz!Box" which has not been published by any installed plugins.

As Andi said. Try the capital platform name like this:

CORRECT: "platform": "FRITZ!Box" WRONG: "platform": "Fritz!Box"

thoschworks commented 3 years ago

I deleted my original text. You should be able to see it in the email notification.

I know that you work on the project on your spare time. I appreciate your work. Thank you!

But also keep in mind that there is some sort of responsibility if a project got traction and hundreds or thousands of users rely on your work. And "I work on it in my spare time" is no satisfiying answer for them, when you broke hundreds or thousands of running installations by a –in my eyes complete unnecessary– change. Especially on a project which is running mostly headless in a dark closet with automated updates and user rely on it without checking it every day, week or month.

andig commented 3 years ago

I deleted my original text. You should be able to see it in the email notification.

@thoschworks you're implying this was an intentional break. It wasn't.

We've had the discussion to revert the (user-contributed!) change after the damage was done and it was declined. If you can make better decisions I'd be happy to hand over this repo to you. If you want to prevent this from happening (and mistakes do happen) you're welcome to contribute unit tests.

If you don't want to contribute at all please stop explaining what my responsibilities are. To be clear and frank: I'm doing the best I can as an open source developer and if that's not good enough- in all openness- please look somewhere else or start improving things.

thoschworks commented 3 years ago

@andig:

I never wrote that you intentional break it. I know that it was unintentional.

(I don't wanted to write one more word about this issue, but after you wrongly accused me that I am implying that you broke it intentional, I think I should make this clear.)