search

andig / moode

Moode audio distribution
3 stars 3 forks source link

Session handling #14

Closed andig closed 9 years ago

andig commented 9 years ago

From what I understand we're reusing the same session for the whole system. Why then are we- on each request- reading the database into the session that is persisted anyway? Would it suffice to do this on first-time installation only? Or rather: why is certain data stored in the session and others in the db?

moodeaudio commented 9 years ago

Are you referring to these calls "playerSession(‘open’”… that appear in multiple scripts?

On Aug 24, 2015, at 2:23 AM, andig notifications@github.com wrote:

From what I understand we're reusing the same session for the whole system. Why then are we- on each request- reading the database into the session that is persisted anyway? Would it suffice to do this on first-time installation only?

— Reply to this email directly or view it on GitHub https://github.com/andig/moode/issues/14.

andig commented 9 years ago

Are you referring to these calls "playerSession(‘open’”… that appear in multiple scripts?

Yep. I don't get why we're attaching to the saved session with all its variables only to read everything from db again?

moodeaudio commented 9 years ago

The comment below in playerSession() function suggests that player_wrk.php maintains separate session id? Very confusing... "// read PHP SESSION ID stored in SQLite datastore and use it to "attatch" the same SESSION (used in worker)"

On Aug 24, 2015, at 7:57 AM, andig notifications@github.com wrote:

Are you referring to these calls "playerSession(‘open’”… that appear in multiple scripts?

Yep. I don't get why we're attaching to the saved session with all its variables only to read everything from db again?

— Reply to this email directly or view it on GitHub https://github.com/andig/moode/issues/14#issuecomment-134165735.

andig commented 9 years ago

suggests that player_wrk.php maintains separate session

No, not separate. The session is used to hand the frontend tasks over to the daemon. Same session. I've implemented the loading now, if it turns out we don't need it then we can still throw it out.

andig commented 9 years ago

Got it half-working. Crunching through tests...