andig / pimatic-fritz

Pimatic plugin for Fritz!Box SmartHome and FritzDect!200 Node
GNU General Public License v2.0
8 stars 6 forks source link

Can't set temperature anymore #39

Closed theslash closed 7 years ago

theslash commented 7 years ago

I get the following error after restarting the Pimatic Service:

error [pimatic]: Invalid config of device " thermo-badezimmer": Property "_temperature" is not a valid property

The Temperature is shown correctly, but I'm not able to set the temperature anymore, I click on the + or - but nothing happens. This worked until a few days ago, FritzOS was 6.60 on 7490 I updated it to 6.83 now, but it didn't help. CometDect version is 3.54

I tried to recreate the Device in Pimatic but it didn't help either.

Any Suggestions?

andig commented 7 years ago

Did you change anything? Update pimatic etc? Anything else in the log file?

theslash commented 7 years ago

Not that I'm aware, I updated another Plugin a few days ago. I just deleted all the Comets and recreated one and just get: Property "_temperature" is not a valid property

Pimatic Version is 0.9.38

theslash commented 7 years ago

Interesting is: when I set the temparature on the Fritzbox to a Value and then edit the Device in Pimatic it sets itself to the same temp but says "Property "_temperature" is not a valid property"

//edit: It reads the set temp from the fritzbox after a a few minutes When I look at the graph in Pimatic it seems to have worked until yesterday evening.

http://imgur.com/a/EF7Yl

theslash commented 7 years ago

Ok, Its somehow related to the Browser, doesn't work in Firefox & Chrome, works in Internet Explorer...sorry for the fuzz...

mwittig commented 7 years ago

@theslash I don't think your issue is related to the browser you're using. Note, however, the Internet Exploder is not supported by pimatic!!! Do you mean "Edge" rather than IE?

nb. the typo is on purpose

theslash commented 7 years ago

@mwittig I know, pimatic works with ie + edge here on my win10 machine. On Firefox 52.0.1 I cant change the temp

matthiasmwolf commented 7 years ago

I have a similar issue, but setting the temperature works in my setup.

andig commented 7 years ago

Could you try deleting these lines https://github.com/andig/pimatic-fritz/blame/cf8fd64e25139a252c2ea85bee918fcdc653422d/fritz.coffee#L362-L365, remove the additional config setting and see if it works then?

I believe that potentially https://github.com/andig/pimatic-fritz/commit/500fbd95676de33448e27448f4136bcde4651b86 was an invalid fix.

matthiasmwolf commented 7 years ago

When deleting lines 362-365 (including the customConfig: keyword) the plugin doesn't seem to work anymore.

image

However, at first I only deleted lines 363-365. The plugin worked, I didn't get a warning, still the key-value-pair "_temperature": NULL showed up.

mwittig commented 7 years ago

I believe that potentially 500fbd9 was an invalid fix.

Yes, and it still looks wrong to me! I think there is still one extra space which should be removed. _temperature should be on the same indentation level as customConfig. You can also remove _temperature if you change the getter as follows:


    getTemperature: -> Promise.resolve(@_temperature?null)
andig commented 7 years ago

Yes, and it still looks wrong to me! I think there is still one extra space which should be removed. _temperature should be on the same indentation level as customConfig.

That would basically revert back to the state the code was in when the issue was opened. Not running pimatic right now I'm lost.

andig commented 7 years ago

@theslash @matthiasmwolf could you kindly check if this finally solves it https://github.com/andig/pimatic-fritz/pull/41 ?