search

andig / videodb

The videoDB media collection software
65 stars 42 forks source link

Use Json data returned from imdb? #200

Open copperhead57 opened 7 months ago

copperhead57 commented 7 months ago

imdb have introduced the use of json data in the returned page holding most of the data that is currently extracted by interrupting the html code.

I have a version in my branch json-blob-imdb using this json data where possible.

any feedback and testing is welcomed.

johanneskonst commented 5 months ago

Your changes look great but collide with my planning ;-)

I had initially opened #152 for this, found #177 to be more pressing as to make a stable foundation in figuring out why something breaks, had a look at #19, #72 and #106 to come to the conclusion that the engines part needed quite some love, and then life happened ...

Would it be wise to make a small plan on the engines we want to support, perhaps give it a base class perhaps for sane defaults, and then build/rebuild from there? I lost my work from beginning '23 but might be able to recreate something...

benausro commented 3 months ago

Imdb parsing works as long as they don't change anything on the site, which they constantly do. I fill my videodb installation with data from tmdb as they provide an api which makes it really easy to gather information. Wouldn't that be the easier and more sustainable way? (I am using python to scrape the data for videodb, I am no php developer, sorry)