andikleen / pmu-tools

Intel PMU profiling tools
GNU General Public License v2.0
1.98k stars 331 forks source link

cputop fails on Alderlake #451

Closed aayasin closed 1 year ago

aayasin commented 1 year ago

I see this after offlining some CPUs, e.g.:

$ ./cputop 'type == "atom"' offline

They cannot be turned on:

$ ./pmu-tools/cputop 'type == "atom"' online
Traceback (most recent call last):
  File "/iusers/ayasin/perf-tools/./pmu-tools/cputop", line 93, in <module>
    if m.group(2):
AttributeError: 'NoneType' object has no attribute 'group'

Even worse, toplev starts to fail:

$ PERF=../perf ./pmu-tools/toplev --version
Traceback (most recent call last):
  File "/iusers/ayasin/perf-tools/./pmu-tools/toplev", line 3720, in <module>
    runner_list = init_runner_list()
  File "/iusers/ayasin/perf-tools/./pmu-tools/toplev", line 3697, in init_runner_list
    cpu_list = get_cpu_list(j)
  File "/iusers/ayasin/perf-tools/./pmu-tools/toplev", line 3669, in get_cpu_list
    return [k for k in read_cpus(fn) if use_cpu(k)]
  File "/iusers/ayasin/perf-tools/./pmu-tools/toplev", line 3658, in read_cpus
    return parse_cpu_list(cpus.readline())
  File "/iusers/ayasin/perf-tools/./pmu-tools/toplev", line 3649, in parse_cpu_list
    if m.group(2):
AttributeError: 'NoneType' object has no attribute 'group'
andikleen commented 1 year ago

Does it work after ab497ac5d43f256bd67f21bcde5f2901226cac64 ?

andikleen commented 1 year ago

Duplicate of #461