search

andikleen / spooky-c

A C version of Bob Jenkins' spooky hash
38 stars 7 forks source link

Ensure that README.md is included in tarball #5

Closed jtlayton closed 9 years ago

jtlayton commented 9 years ago

One more minor patch. This is needed to ensure that the README.md file is included in "make dist" tarballs.

Also, would it be ok to tag this at v1.0.0 for a release? I've done so in my repo, but I'm not sure that tags come across in pull requests.

andikleen commented 9 years ago

I had to merge it manually and also fix your previous commit. My autoconf didn't like AM_INIT_AUTOMAKE([foreign])

jtlayton commented 9 years ago

Really? Odd. That's a pretty standard automake macro and not having it there breaks ./configure for me:

checking for stdint.h... yes checking for unistd.h... yes checking minix/config.h usability... no checking minix/config.h presence... no checking for minix/config.h... no checking whether it is safe to define EXTENSIONS... yes configure: error: cannot find install-sh, install.sh, or shtool in "." "./.." "./../.."

Technically that macro is an automake macro. Do you not have automake installed by chance?

andikleen commented 9 years ago

automake is installed: % rpm -q automake automake-1.13.4-5.1.2.noarch % rpm -q autoconf autoconf-2.69-10.1.2.noarch

When I revert the change. Just doing autoreconf -i ; ./configure

the configure fails with

checking whether to build static libraries... yes ./configure: line 11408: AX_CHECK_ALIGNED_ACCESS_REQUIRED: command not found checking that generated files are newer than configure... done

But at least it builds.

I think the working generated files need to be checked in at least, also for someone who doesn't have the newest linux.

To be honest I'm tempted to revert everything as the whole thing seems very troublesome. What was the advantage again? Probably at least need the old Makefile as fallback