search

andim / noisyopt

Python library for optimizing noisy functions.
http://noisyopt.readthedocs.io/
MIT License
87 stars 15 forks source link

JOSS review: installing dependencies via pip #4

Closed nirum closed 7 years ago

nirum commented 7 years ago

Hi,

I'm trying to install noisyopt in a clean conda environment running python 3.5. Running pip install noisyopt does not install the dependencies (numpy, scipy). I see that you do include a requires keyword argument in your setup.py file, does this need to be install_requires? (as in https://packaging.python.org/requirements/).

Also, not necessary if you don't want to, but I think it would be good to include a list of dependences somewhere in the README.

nirum commented 7 years ago

(edit: just noticed the dependencies are listed in the Installation section in the README)

andim commented 7 years ago

Thanks for noticing this! Fixed this in 7c0c40ee4d9d229e9514f4e4e33695d409ecfed5

nirum commented 7 years ago

Thanks! Mind pushing an update to pypi? you could just bump the version to 0.2.1