Symdel progress - Githubissues

andim / pyrepseq

Python library for immune repertoire analysis

MIT License

15 stars 4 forks source link

Symdel progress #46

Closed MVCowley closed 3 months ago

MVCowley commented 3 months ago

Issue: For large lists, nn.symdel can take an extended amount of time. It would be helpful to see the progress of the algorithm.

Solution: Add an optional tqdm progress bar to the main loop of _symdel_lookup.

Changes:

Add tqdm dependency
Add new progress argument to both symdel and symdel_lookup
Add logic to wrap enumerate(seq2) if progress=True, by default it is false and behaviour is unchanged
Uses tqdm.auto.tqdm to support both CLI and notebooks
Add unit test for progress functionality

Let me know if you'd like any changes!

MVCowley commented 3 months ago

No worries! Would you be happy to push a minor release to PyPi so Decombinator can use the new feature?