Closed dasJ closed 1 year ago
Thank you, this looks pretty solid. Some quite notes:
auth_token
or access_token
would be preferable?access_token
during development but I changed it to private_token
. This is the relevant docs so if you want me to change it, I will?private_token=…
is appended to the URLSince the added field may be required for private repositories to successfully fetch, older versions can't really ignore it. Therefore, I'm in favor of incrementing the format version.
Please don't forget to add unit tests for the new fields/logic in the GitLab case. We shouldn't let those fall behind. Especially if we can't (easily) have an integration tests those should be present.
Added tests, added more docs, added token via environment, bumped the version
Andi mach release
piegames macht release
We kind of need this