andir / npins

Nix dependency pinning. Very similar to Niv but has a few features that I personally wanted.
European Union Public License 1.2
199 stars 16 forks source link

Add support for gitlab private repositories #33

Closed dasJ closed 1 year ago

dasJ commented 2 years ago

We kind of need this

piegamesde commented 2 years ago

Thank you, this looks pretty solid. Some quite notes:

dasJ commented 2 years ago
piegamesde commented 2 years ago

Since the added field may be required for private repositories to successfully fetch, older versions can't really ignore it. Therefore, I'm in favor of incrementing the format version.

andir commented 2 years ago

Please don't forget to add unit tests for the new fields/logic in the GitLab case. We shouldn't let those fall behind. Especially if we can't (easily) have an integration tests those should be present.

dasJ commented 2 years ago

Added tests, added more docs, added token via environment, bumped the version

dasJ commented 1 year ago

Andi mach release

piegamesde commented 1 year ago

piegames macht release