search

andischerer / atom-svn

SVN integration for atom text editor
MIT License
34 stars 7 forks source link

Allow config of svn binary location. #16

Closed ezarko closed 7 years ago

ezarko commented 8 years ago

Uses atom.config.get() to fetch location of svn and svnversion, and if not set defaults to using path as before.

ezarko commented 8 years ago

I have tested this on my machine and it does work!

Arcanemagus commented 8 years ago

It doesn't look like you are defining this configuration anywhere...? You may want to peruse the documentation.

0rvar commented 8 years ago

As @Arcanemagus pointed out, the PR lacks changes to the configuration schema. If you could add that, perhaps we could get this merged.

0rvar commented 7 years ago

I am closing this due to inactivity. Feel free to create a new pull request in the future.