search

andismith / grunt-responsive-images

Produce images at different sizes for responsive websites.
http://www.andismith.com/grunt-responsive-images/
MIT License
719 stars 96 forks source link

maintain sub directory structure #18

Closed tmaslen closed 10 years ago

tmaslen commented 10 years ago

@andismith this pull request is now ready.

andismith commented 10 years ago

Thanks, I'll merge when I get a chance to review it.

andismith commented 10 years ago

Thanks @maslen for this pull request.

andismith commented 10 years ago

Did the tests pass for you with this change? I have 4 tests failing. Not sure if the failures are coming from custom_dest or maintain_sub_directory_structure. Just debugging now, but if you have any insight that would be helpful :)

andismith commented 10 years ago

It's ok, I've figured it.

andismith commented 10 years ago

Included in v0.0.6

tmaslen commented 10 years ago

Tell us what you did?

The tests I wrote always pass on my machine but the original tests have never passed. But its impossible to debug as the equals assert outputs the binary of the image. NodeUnit could do with a binaryEqual or a output suppression option for the test.

andismith commented 10 years ago

Interesting, it must be the way the images are generated from machine to machine. I'll open up a new issue about this and perhaps we can figure out a way to fix this.