search

andismith / grunt-responsive-images

Produce images at different sizes for responsive websites.
http://www.andismith.com/grunt-responsive-images/
MIT License
719 stars 96 forks source link

fix undesirable upscaling small images #45 #79

Open isaacchansky opened 9 years ago

isaacchansky commented 9 years ago

This adds a test and a fix for the issue of small images getting upscaled ( #45 ).

For example, I run a default image resizing job and want three directories (small, med, large). I also want to have image paths for an icon at: small/icon.png, med/icon.png, large/icon.png. But, if the original icon size is 48x48px, I want it to remain be no bigger than the original, even in the large directory.

The only difference in any API's now should be that to upscale small images, you must opt-in via upscale:true . Not sure if this might be a breaking change because of this.

sontan commented 8 years ago

Hey, @andismith! We are struggling with issue #45 and it would be nice to have this fix in upstream. Is there any problems with this PR?

aaronwolen commented 8 years ago

:+1: