search

andk / cpanpm

CPAN.pm
87 stars 79 forks source link

cpan ignores -x option #112

Closed Tux closed 7 years ago

Tux commented 7 years ago

The cpan interface allows close matching on misspelled module names using the -x option and and form of Text::Levenshtein is installed. That option however is ignored and the guessing will take place always if any of these modules is installed

$ time cpan App::Cpax 0.9 seconds

with Text::Levenshtein installed $ time cpan App::Cpax 99.0 seconds

This is to disable the quessers when any of those guessers in installed

After this change (trimmed output):

$ time cpan Text::CSC_XS Could not expand [Text::CSC_XS]. Check the module name. Skipping Text::CSC_XS because I couldn't find a matching namespace. 0.820u 0.388s 0:01.21 99.1% 0+0k 0+16io 0pf+0w

$ time cpan -x Text::CSC_XS Checking 168232 namespaces for close match suggestions Text::CSV_XS Text::CSV_PP Test::CSS Text::CSV2TXT Text::CSV Text::CSV::R Text::CHM Text::TOC Text::Chart Text::MeCab 114.100u 0.868s 1:55.02 99.9% 0+0k 560+55112io 2pf+0w

andk commented 7 years ago

@briandfoy : I'm leaning towards accepting the PR, do you have any reason not to? I mean, it looks like it implements the original intention, does it not? I guess it's always better to give the user the choice to turn features on and off.

briandfoy commented 7 years ago

Looks good to me. Thanks,

andk commented 7 years ago

Merged as per brian's endorsement. Thanks!