andk / cpanpm

CPAN.pm
87 stars 79 forks source link

first time setup on cygwin with strawberry also installed picks up wrong patch executable, leading to an endless loop #145

Open wchristian opened 3 years ago

wchristian commented 3 years ago

I get:

Press SPACE and ENTER to disable patch Press SPACE and ENTER to disable patch Press SPACE and ENTER to disable patch Press SPACE and ENTER to disable patch

The executable it finds is:

/cygdrive/c/Strawberry/c/bin/patch
$ patch --version
patch 2.5.9
[...]

I can workaround this locally by installing cygwin's patch package.

/usr/bin/patch
$ patch --version
GNU patch 2.7.4
[...]

However i think the first time setup should recognize that the patch it found is not the one it needs, whether this happens due to matching the version string, or by rejecting any patch that is in /cygdrive.