andk / cpanpm

CPAN.pm
87 stars 79 forks source link

2021 download must have SSL support #151

Closed xdg closed 2 years ago

xdg commented 2 years ago

localize_2021 checks for HTTP::Tiny+SSL support or curl/wget, but hostdl_2021 only checks for the presence of HTTP::Tiny regardless of SSL support so it never falls back to curl/wget. So if HTTP::Tiny is available but without SSL, and curl/wget is configured, CPAN will happily try HTTP::Tiny and fail to download from an https URL.

I've tested this change manually on a fresh box (where I discovered this) but someone should review it and do additional testing just in case I messed up the copy/paste somehow.

andk commented 2 years ago

Thank you, David, well spotted!