search

andk / cpanpm

CPAN.pm
87 stars 79 forks source link

RT-145462: cpan(1) log message uses the wrong key #167

Open briandfoy opened 1 year ago

briandfoy commented 1 year ago

I'm transferring and splitting up some issues reported in App::Cpan many problems, multiple fixes.

In App::Cpan::_download, the log line uses the wrong variable as a hash key:

$logger->info( "Downloaded [$arg] to [$paths{$arg}]" );

It should be:

$logger->info( "Downloaded [$arg] to [$paths{$module}]" );

This is related to #162 with some rearranging that needs to happen for track errors and return the appropriate values.

Patch provided by "eponymous alias" eponymousalias@yahoo.com in the RT ticket App.Cpan.patch.txt

x-yuri commented 1 year ago

Indeed, right now cpan -g exits with an error (although the operation succeeds). The issue seemed to be fixed, but soon broken again.