search

andk / pause

Perl authors upload server
http://pause.perl.org/
150 stars 57 forks source link

Fix warning about spurt #524

Closed rspier closed 4 months ago

rspier commented 4 months ago

Mojo::File::spurt is deprecated in favor of Mojo::File::spew at t/pause_2017/action/add_uri.t line 37.

charsbar commented 4 months ago

This is only acceptable when the version of Mojolicious in the production server is upgraded to the version 9.34 or higher. cf. https://metacpan.org/dist/Mojolicious/changes#L18 and https://metacpan.org/dist/Mojolicious/changes#L22

rspier commented 4 months ago

Looks OK to me.

/home/pause/.plenv/shims/perl
pause@pause3:~$ perl -MMojolicious -le'print $Mojolicious::VERSION'
9.36
rspier commented 4 months ago

@rjbs Do we want to pin all the versions so they line up between test and prod to try and prevent surprises?

wolfsage commented 4 months ago

@rjbs Do we want to pin all the versions so they line up between test and prod to try and prevent surprises?

IMO yeah, our builds should give us the same setup as prod

rjbs commented 4 months ago

@rspier Yes.

rspier commented 4 months ago

tracking that in #529