andkret / Cookbook

The Data Engineering Cookbook
https://learndataengineering.com/
Apache License 2.0
13.75k stars 2.51k forks source link

make language more inclusive/generic #44

Closed kenzshelley closed 5 years ago

biglovisa commented 5 years ago

I was just about to put up a PR for this 👍 ✨

andkret commented 5 years ago

Thanks, but I'm not going to make these types of changes to how I talk and write.

kenzshelley commented 5 years ago

¯_(ツ)_/¯ your repo, your decision.

As a data engineer who isn't a guy, it stuck out to me when I skimmed the beginning of your doc. I sent the PR because I assumed that it was probably unintentional, and that you'd prefer not to potentially alienate a subset of the people who may be interested in reading your content.

biglovisa commented 5 years ago

As an aspiring data engineer who isn't a guy, I completely agree. Words and language matter. But - your repo, your decision.

VikiAnn commented 5 years ago

What a strange response to a kind gesture.

rwarbelow commented 5 years ago

@andkret out of curiosity, were you intending for your original wording to be male-specific?

corneliusellen commented 5 years ago

As an engineer who also isn't a guy who also used "guys" as synonymous with "people", I agree with this change. (Heck, I even used to say "you guyses!" - it's the oafish Midwesterner in me).

@andkret I don't think this PR is an attack on how you write and talk. It just seems like a grammatically correct and more inclusive suggestion to a public facing repo.

robbkidd commented 5 years ago

From the README:

It's not only useful for beginners, professionals will definitely like the case study section.

"Engineers" is an improvement if the material is intended to appeal to more than male beginners and professionals. It's a simple change to accept and doesn't break the build.

GeekOnCoffee commented 5 years ago

As a guy, this is an easy change I've worked hard to make to be more inclusive.

In this case, it would have been easier to hit the merge button than to type the response. I'd ask you to reconsider this simple change to make your language more inclusive.

keithrbennett commented 5 years ago

I've come to realize that sometimes something that isn't a big deal to me is a big deal to someone else, because of their life experience. Also that sometimes something requiring very little effort for me can be disproportionately helpful to someone else. I would hope that you wouldn't look at this request as an imposition or censorship, but rather an opportunity to help your female colleagues feel valued and welcomed. They've asked very respectfully and nicely, and it seems to me that agreeing to their request would be a good thing for all individuals involved, and the community as a whole.

ccompeau commented 5 years ago

There is a community of people here who can make your work better and more widely appealing, basically for free. That is, if you’ll let them. This wasn’t a proposal for a substantial change to the main thrust of the work, and would have been simple enough to accept and have a happier audience. Why dig in and die on this particular hill? We all have blind spots. That’s ok. This is what editors are for - they can see what you can’t.

robbkidd commented 5 years ago

Imagine that English is a dynamic, interpreted language. ( ... 🤔) OK, it is that, so imagine that English is a dynamic, interpreted programming language.

At least five users have reported that they are experiencing WARN-level deprecation messages when ~reading~ running your Cookbook. In their feminine English runtimes, the use of "guys" to refer to a group of people has been deprecated unless it is referring to a group of men. (This change has been validated on masculine runtimes where tests for "How many guys have you dated?" returned only a count of males—and in some extreme cases threw exceptions—that the deprecation has been adopted.)

It is true that the Cookbook still compiles and runs in their production environments. But the noise generated by the WARN messages is distracting to the operators trying to get benefit from your good work.

One of the users has submitted a fix that worked for her English runtime. Four other users reported no WARN deprecation messages in their similar feminine runtimes. Four additional users reported that the fix does not break in their masculine runtimes. A one word change has made your Cookbook multi-platform.

"Closed, won't fix" for this seems like "Runs on my machine. I do not want to support feminine runtimes."

armahillo commented 5 years ago

This seems like such an obviously correct change it's weird to imagine anyone would complain about it.

Yes, the change is good; ship it :)

benreyn commented 5 years ago

Agree with all points here. As far as I can see it, this costs nothing and has a net positive impact.

+1 LGTM 👍

ejuten commented 5 years ago

It looks like the term 'engineer' is used in the following paragraph, I like the consistency and inclusivity of that term throughout.