andkulikov / Transitions-Everywhere

Set of extra Transitions on top of Jetpack Transitions Library
Apache License 2.0
4.82k stars 486 forks source link

Prevent leaking the current context in an static ArrayMap. #37

Closed raycoarana closed 8 years ago

raycoarana commented 8 years ago

The current implementation has a big problem as it leaks the Context used to create the TransitionInflater in an static ArrayMap. When used with an Activity context it could leak the entire activity.

This code is already removed from the TransitionInflater class from Android as you can see here:

https://android.googlesource.com/platform/frameworks/base/+/58ad12208afcf9fdce735dead8449c4db375344d%5E%21/#F0

andkulikov commented 8 years ago

Oh, I've missed that commit. thank you!

gmerinojimenez commented 8 years ago

Seems nice! :)

andkulikov commented 8 years ago

released in 1.6.4