search

andkulikov / Transitions-Everywhere

Set of extra Transitions on top of Jetpack Transitions Library
Apache License 2.0
4.83k stars 486 forks source link

Crash on Recycler view expand animation #74

Closed Sottti closed 6 years ago

Sottti commented 6 years ago

Apparently, this is common to both libraries.

https://issuetracker.google.com/issues/37129527

andkulikov commented 6 years ago

@Sottti Hey. Are you sure its still crashing with the latest Transitions-Everywhere? I fixed a similar issue in version 1.7.3. its related to any visibility transition like Fade. Also I am trying to reproduce it, but in my local build Plaid always stuck on the progress bar instead of comments like its unable to load them

andkulikov commented 6 years ago

the fix is https://github.com/andkulikov/Transitions-Everywhere/commit/0d977dd7dddee12bdb02f78b1d4c10d649190b26

andkulikov commented 6 years ago

Ok, I managed to make Plaid works. And I see that its crashing on com.andkulikov:transitionseverywhere:1.7.2 but not on the latest com.andkulikov:transitionseverywhere:1.7.6 So please check next time before creating a bug is it really reproducible. I will also add a comment into the google issue, to help to fix it support library as well