search

andkulikov / Transitions-Everywhere

Set of extra Transitions on top of Jetpack Transitions Library
Apache License 2.0
4.83k stars 486 forks source link

Scene class is final ?? #79

Closed LLudoDev closed 6 years ago

LLudoDev commented 6 years ago

Hi, why the Scene class is final ? I am working on an technical architecture based on the Scene class and i need to override it. Then, is the final keyword optionnal are not ?

andkulikov commented 6 years ago

Hi. My library is just a backport of Transitions from Android Framework. There Scene class is final, that why it is final here as well. Why do you need to override it, why can't you use a composition there?

LLudoDev commented 6 years ago

With the android.support.transition.Scene i could override the Scene that’s why i asked that. Ok, then i will still use the Scene object as a composition. Thx !

andkulikov commented 6 years ago

I have no idea why do they removed final in support lib but I still suggest to not override it