Transitions Everywhere uses Reflection that may crash on P+ devices

andkulikov / Transitions-Everywhere

Set of extra Transitions on top of Jetpack Transitions Library

Apache License 2.0

4.83k stars 486 forks source link

Transitions Everywhere uses Reflection that may crash on P+ devices #90

Closed TealOcean closed 5 years ago

TealOcean commented 5 years ago

See: https://developer.android.com/about/versions/pie/restrictions-non-sdk-interfaces

It appears ReflectionUtils is the primary problem, but it would appear the usages of reflection may become a problem with P.

There are published lists of APIs that will break on P (https://android.googlesource.com/platform/prebuilts/runtime/+/master/appcompat).

andkulikov commented 5 years ago

It is not an issue on Android Pie. All the reflection calls library is using are allowed currently. The reason behind it - AndroidX(Support) Transition Library is also using the same methods. But it will be changed together with the next Android release. AndroidX library will stop use this methods and I will recommend migrate to AndroidX from Transitions Everywhere by this moment

TealOcean commented 5 years ago

Cool, so just to clarify, is the guidance to use the support library variant of transitions once the next release goes out (The Android X one)?

andkulikov commented 5 years ago

I joined Google and fixed bugs I knew about AndroidX Transitions. It should be released in the next alpha version. Later I will provide a migration guide when it will be ready

andkulikov commented 5 years ago

Please check out the main README file. I released version 2.0.0 of Transitions-Everywhere based on AndroidX transitions and provided a migration guide.