search

andlabs / ui

Platform-native GUI library for Go.
Other
8.33k stars 651 forks source link

Go security release (1.8.7 / 1.9.4) breaks package compilation #268

Closed rasky closed 6 years ago

rasky commented 6 years ago

Description of the Go fix that breaks compilation: http://golang.org/issue/23672

LDFLAGS now has a whitelist in place for options it accepts, and it doesn't accept bare filenames. This breaks compilation of ui.

https://github.com/andlabs/ui/blob/2dde2a79e7020f065d94d9bc17e0191bf18a5bff/link_linux_386.go#L8

There should probably be a -l added in front of the base library name, and a -L for the directory.

andlabs commented 6 years ago

I cannot make any fixes currently. What would the equivalent fix on Windows be (note that it needs to link to a .res file as well)?

andlabs commented 6 years ago

Fixed by Go itself. See also https://github.com/golang/go/issues/23749