search

andland / logisticPCA

Dimensionality reduction for binary data
Other
49 stars 9 forks source link

Improved performance slightly #1

Closed wrathematics closed 9 years ago

wrathematics commented 9 years ago

Well github ate my last pull request; let's see how this one goes.

This seems like a neat idea, but the performance isn't great. I moved the inv.logit.mat() function to C as that seemed like the lowest hanging fruit, but more could be done.

wrathematics commented 9 years ago

I added a few more tweaks. On a 2000x100 matrix, the timings pretty reliably go from ~3 seconds to ~1.8 on this machine, almost a 70% improvement in run time. There's also a lot less storage that gets used.

The PR includes numerous packaging fixes as well, and the package now passes R CMD check.

To clarify the change of the LICENSE file, for certain licenses, including MIT, CRAN policy is such that you can't list the full license. They ship a template license file with R, and then you "fill in the blanks", as in my commits. The project is still MIT licensed (see the DESCRIPTION file), but this is the way of things with CRAN. I've actually gotten denied in the past from getting a BSD licensed project on the CRAN because I didn't follow this policy correctly. This is explained here and here.

If you accept, please consider listing me as a contributor to the package.

Thanks!