search

andmarti1424 / sc-im

sc-im - Spreadsheet Calculator Improvised -- An ncurses spreadsheet program for terminal
Other
4.77k stars 201 forks source link

Memory leaks froze my pc #856

Closed TheYellowArchitect closed 8 months ago

TheYellowArchitect commented 8 months ago

I wanted to give a try at https://github.com/andmarti1424/sc-im/issues/486 I just wanted to search through this repo for that command option, hoping its an easy task (I am a newbie with linux) I built according to the guide at README.md but couldn't find how to execute that local binary (where is that binary?)

Anyway, I ran the unit tests at tests/run_all_tests.sh (or was it assert.sh) anyway, first time it ran succesfully, then I ran it again, and it froze. Hard. Like, no input, no mouse no keyboard, had to reboot manually... Please remove these tests if they are reproducible, they can harm someone's computer.

P.S. I probably ran them with sudo rights since my user is sudo by default (yes, I recognize it's bad practice)

andmarti1424 commented 8 months ago

Hello. Why you say there is a leak? Did you run sc-im with Valgrind or other tool and saw this?

TheYellowArchitect commented 8 months ago

Because I have run plenty of wild/random software, and my linux has never behaved this way before. Never before have I experienced input freeze (something which is normal in Windows with certain unoptimized programs) Even if I run an infinite loop in bash, I can just kill the window (dwm), it wouldn't corrupt my entire pc (and on reboot it said something about RAM)

Here is the argument for memory leak, without the usage of any software: It completed the first time without issues, and since unit tests are supposed to be deterministic, it doesn't make sense for the 2nd time to cause issues. This means the state of the computer changed, and this can be true only if the memory was changed, hence my assumption for memory leak. If it wasn't a memory leak, with the same input, there should be the same output ;)

andmarti1424 commented 8 months ago

I run all these tests with valgrind without any memory leaks in the log shown. please rerun those tests with valgrind and report back. if there is a memory leak you should see it in the log. thanks.

TheYellowArchitect commented 8 months ago

It sounds like a case of "it works on my machine" I refuse to run that script again, as it was harmful to my hardware. Solving a bug by risking my entire computer + the time I have spent on configuring it is just not worth it.

If you wish, close this issue, I only wanted to report this bug.

luna-in-space commented 8 months ago

I don't understand how you can know this is a memory leak with no documentation. For all anyone knows there could be a million other things that caused this to happen unless you run it through valgrind.

On December 7, 2023 6:44:08 PM GMT+01:00, TheYellowArchitect @.***> wrote:

It sounds like a case of "it works on my machine" I would love to help on this, but there is no way I will run that script again, as it was harmful to my hardware. If you wish, close this issue, I only wanted to report this bug.

-- Reply to this email directly or view it on GitHub: https://github.com/andmarti1424/sc-im/issues/856#issuecomment-1845812191 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

andmarti1424 commented 8 months ago

I agree with @luna-in-space. @TheYellowArchitect if you happen to run these with valgrind, please share the log. thanks again.