Fixed theme toggling bug - Githubissues

andoriyaprashant / OpSo

OpSo is a Flutter app that provides comprehensive information about various open-source programs

MIT License

35 stars 59 forks source link

Fixed theme toggling bug #229

Closed Mastermind-sap closed 1 week ago

Mastermind-sap commented 1 week ago

Problem / Issue No.

Closes #228

Describe Problem / Root Cause

When you first build the app on any device or install it for first time, it initializes the theme to system's default theme. If the system theme is light mode there is no visible error but if it is dark mode the toggling button will skip the press for one click as it will set System (presumed to be Light mode by the code given in home_page.dart )mode to Dark mode first.

Solution proposed

I have taken initial theme as the light mode and toggled between the dark and light modes which were defined in the program from before.

Additional Information

Moreover it is saving the theme currently upon closing the app if it doesn't we can store it using shared pref.

Screenshots

Original Screenshot (Problem/Issue)

https://github.com/andoriyaprashant/OpSo/assets/66560136/9b64c13a-65e8-48f5-a5ad-6f2e2e665292

Updated Screenshot (Fixes/Solution)

https://github.com/andoriyaprashant/OpSo/assets/66560136/6684c4b0-6265-462d-be43-9246665b3b23

github-actions[bot] commented 1 week ago

Thank you for submitting your pull request! We'll review it as soon as possible.