search

andorsk / d2-mode

emacs major mode for d2 graphs
GNU General Public License v3.0
69 stars 8 forks source link

Implement indentation #47

Closed MoisMoshev closed 3 months ago

MoisMoshev commented 4 months ago

Fixes #45 Implements simple parsing of current and previous lines, and calculation of indentation, depending on the syntax. It is still a bit rough, the regexes might have to be adjusted.

andorsk commented 3 months ago

@MoisMoshev thank you for the PR. I will review, and if things go well, merge it in. Thank you for the contribution!!!

andorsk commented 3 months ago

@MoisMoshev I am really swamped this week, but will look at it in more detail either later half of the week or this weekend. This is going to a major feature in the next version of the release. Thank you very much for contributing the PR!

MoisMoshev commented 3 months ago

Excellent, makes me very happy! I'll be away next week (would probably be checking here in read-only mode) so I might not be able to react if intervention is needed on my side.

andorsk commented 3 months ago

Perfect. Thanks @MoisMoshev. Will get this merged in asap. Something came up this weekend and going to have to delay my review until mid next week. my apologies. I'm looking forward to the review.

andorsk commented 3 months ago

@MoisMoshev firstly, thank you for the PR. I really appreciate it. I would love to get it in, but there are some problems. Would you mind taking a look at some of the comments and seeing if you could fix them?

andorsk commented 3 months ago

@MoisMoshev once the build checks are passing, I'll be happy to re-evaluate this and try to merge it in. The PR was really helpful. Thank you again.

MoisMoshev commented 3 months ago

Thanks, I'll take care of it in the coming days.

MoisMoshev commented 3 months ago

Everything fixed

andorsk commented 3 months ago

Everything fixed

Running everything over CI/CD. Then will check locally. If looks good, will merge in. Thank you!

MoisMoshev commented 3 months ago

Some seem like an issue in the environment, e.g.: Error: Packages could not be installed:\n Failed to verify signature: "let-alist-1.0.6.tar.sig"

This one I might have to fix: [ELISP-CHECK] Running check: elisp-check-checkdoc Error: Probably "matches" should be imperative "match"