search

andorsk / d2-mode

emacs major mode for d2 graphs
GNU General Public License v3.0
63 stars 7 forks source link

fix: handling of d2-flags #48

Closed terlar closed 4 weeks ago

terlar commented 1 month ago

They were only passed to the org babel execution and not to the regular compile file command.

This also converts it to a list instead of a string in order to better fit the call-process function.

andorsk commented 1 month ago

thank you for the improved handling and PR! Will review and hopefully can merge this in!

terlar commented 1 month ago

Thank you, just a heads up, I did change the d2-flags from a string to a list. We could also keep it as a string for backwards compatibility. I guess that is the main "questionable" change.

andorsk commented 1 month ago

@terlar, thanks for being patient. Can we get string-join added in above, and make sure the builds above are fixed? Should be good to go after that.

andorsk commented 4 weeks ago

note: ci is breaking due to some weird upstream issues, but one from each os ( mac, windows, and ubuntu ) all passed, so I think this is fine.

New issue tagged here: https://github.com/andorsk/d2-mode/issues/49 for this. LGTM, and approved.