search

andosa / treeinterpreter

BSD 3-Clause "New" or "Revised" License
745 stars 140 forks source link

Should aggregation be the sum over absolute contributions? #23

Open chathika opened 5 years ago

chathika commented 5 years ago

In line 6 of aggregated_contribution the individual contributions are summed.

Shouldn't the contributions be converted to their absolute values first and then summed?

For example, a joint feature, that has both high negative and low negative contributions would get a low aggregated joint contribution as of the current implementation?