My bad, I did not properly check #29, and this now causes an
ImportError: cannot import name 'ForestClassifier' from 'sklearn.ensemble'
upon loading this library.
Sklearn 0.22+ seems to have removed public access to the base classes ForestClassifier and ForestRegressor. This PR changes the type checking to use more concrete implementations RandomForestClassifier, ExtraTreesClassifier, RandomForestRegressor, ExtraTreesRegressor. I think this is a better approach anyway, as sklearn may decide to add more forests type models which we cannot guarantee to support.
My bad, I did not properly check #29, and this now causes an
upon loading this library.
Sklearn 0.22+ seems to have removed public access to the base classes
ForestClassifierandForestRegressor. This PR changes the type checking to use more concrete implementationsRandomForestClassifier,ExtraTreesClassifier,RandomForestRegressor,ExtraTreesRegressor. I think this is a better approach anyway, as sklearn may decide to add more forests type models which we cannot guarantee to support.