andoshin11 / spa-playground

TBD

3 stars 0 forks source link

Feature/unit test utils #18

Closed andoshin11 closed 5 years ago

andoshin11 commented 5 years ago

Summary Collect coverage from utils methods.

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All lines for debugging use are removed
[ ] All tests are passing
[ ] Lint checks are passing
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Screenshots

Other information:

reg-suit[bot] commented 5 years ago

reg-suit detected visual differences.

Check this report, and review them.

:white_circle::white_circle::white_circle::white_circle::white_circle::white_circle::white_circle:

What balls mean?

The number of balls represents the number of images change detected.
:red_circle: : Changed items, :white_circle: : New items, :black_circle: : Deleted items, and :large_blue_circle: Passed items

How can I change the check status?

If reviewers accepts this differences, the reg context status will be green automatically.

codecov[bot] commented 5 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      3    +1     
  Lines          20     32   +12     
  Branches        0      2    +2     
=====================================
+ Hits           20     32   +12

Impacted Files	Coverage Δ
src/utils/utils.ts	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d08354...50d3ea3. Read the comment docs.

andoshin11 commented 5 years ago

Looks like we need to work on regression test 😞