search

andpor / react-native-sqlite-storage

Full featured SQLite3 Native Plugin for React Native (Android and iOS)
MIT License
2.75k stars 521 forks source link

New sqlite libraries for Android native #492

Open leorajdsouza opened 2 years ago

leorajdsouza commented 2 years ago

Updating the code lib fixed the #462 issue.

Tested Environments: RN: 0.62.1 Device: S21 Android 11

rblalock commented 2 years ago

Ohhh interesting. sounds like this is my problem too

rblalock commented 2 years ago

Is there anything I can do to help get this through? Testing? etc?

zzorba commented 2 years ago

Quite interested in this as well, especially on builds with targetSdkVersion: 30, which became standard with RN 65+. By my read targeting version 30 causes Android to enforce the new file system permissions fully.

rblalock commented 2 years ago

@zzorba Ref. my comment here, maybe it'll help? https://github.com/andpor/react-native-sqlite-storage/issues/462#issuecomment-941580281

zzorba commented 2 years ago

@rblalock thank you for this suggestion, I was strongly considering moving back to the built in SQLite, I just was trying to remember why I might have put the embedded version in to begin with.

Edit: and as I suspected, supporting old android versions forced me to use the full SQLite implementation, since older OSes don't support the on conflict operations that typeorm is using in my current setup.

andpor commented 2 years ago

There are conflicts. Also, can you confirm if all required functionality/features for native libs are working fine (use JSON test file in examples directory). Please reach out to the contributor of those libraries to make sure everything is covered and working.

andpor commented 2 years ago

Is there anything I can do to help get this through? Testing? etc?

Yes @rblalock - testing/validation would be great. I have seen people having issues with JSON support and other things glancing through the original issue.