andras-simonyi / citeproc-org

Renders Org-mode citations in CSL styles using citeproc-el.
GNU General Public License v3.0
68 stars 2 forks source link

Respect org-ref-default-bibliography #2

Closed dcherian closed 6 years ago

dcherian commented 6 years ago

When bibliography: is not present, citeproc-org should use the value in org-ref-default-bibliography

andras-simonyi commented 6 years ago

Thanks! The reason why this is not already in the code is that the bibliography link has two roles, specifying the bibliography file to use and the location where the bibliography should be placed. Do you think citeproc-org should simply place the bibliography at the end of the document if the bibliography link is missing but org-ref-default-bibliography is set? (Another option would be to omit the bibliography and render only the citations...)

dcherian commented 6 years ago

Yes placing it at the end would be a good default

dcherian commented 6 years ago

This would also take care of the case where only bibliography: here is specified in the document?

andras-simonyi commented 6 years ago

I've pushed some changes to the master branch which should take care of missing bibliography links and links with "here" as the target. Note that the value of org-ref-default-bibliography is a list, but citeproc-el currently works only with single bibliography files so the first file in the list is used.

dcherian commented 6 years ago

Sounds good. I'll test it tomorrow. Thanks!