search

andrasferenczi / vitrina-legacy

A companion app for Muzei that fetches images from Reddit
24 stars 9 forks source link

Fix broken Subreddit search #14

Closed gitanshu closed 3 years ago

gitanshu commented 3 years ago

Close #13

Currently the subreddit search shows 'Something went wrong' on the UI. The extra space in auth header has been causing the auth request to throw 401. Removing the space fixes it.

andrasferenczi commented 3 years ago

It would take too long to build a new version of the APK. Unfortunately, I cannot afford to put that much time into this now. (Importing the project is not working, I just can't bother with JVM, Gradle, AS dependencies now.)

MoriTanosuke commented 3 years ago

I upgraded gradle to the minimum required settings and was able to build+install this PR on my device and I can now successfully add subreddits again. Attached is a small patch file with necessary changes.

upgrade_gradle.patch.txt

MoriTanosuke commented 3 years ago

Locally I removed everything related to firebase and googlemessaging. Attached to this comment is the full patch of those changes, in case only doing the minimal upgrade isn't working for you.

remove_firebase.patch.txt

andrasferenczi commented 3 years ago

@MoriTanosuke thank you so much! This really did solve the compilation issue.

ThatFunnyGuyver commented 3 years ago

GitHub people FTW. My heart is so warm right now.

andrasferenczi commented 3 years ago

Thank you @MoriTanosuke and @gitanshu for keeping the project alive and others for letting me know they are still using this app. You guys are awesome!

Release v34 should be out pretty soon, PR #16 has been created where I've merged all the code.