search

andrasferenczi / vitrina-legacy

A companion app for Muzei that fetches images from Reddit
24 stars 9 forks source link

Disable delete for fav images, and allow us to add our own images to the vitrina folder #18

Open tdbe opened 3 years ago

tdbe commented 3 years ago

Vitrina is the only good user defined wallpaper source for muzei. But it needs a bit more customizabiliy.

99% of the time my vitrina UX is like this (and I imagine others have similar issues):

Other non-muzei apps, such as Wallpaper Changer, simply allow you to browse for a folder (or a few different folders) on your phone's storage, and displays wallpapers from there. (of course it doesn't also download images from reddit / pixiv / deviantart / artstation...)

Partly related to this issue as well: #11

PS: probably the ideal setup would be for Vitrina to have a favourite / "don't delete this image" function, and then the wallpaper display formula should be e.g. random * 1/age so it shows new images more often than old images so you don't get bored of the old favorites. Maybe I'll implement that myself, but I'm busy rn.

andrasferenczi commented 3 years ago

@tdbe these are all great suggestions, but also quite a lot to implement. I don't think I can afford to put that much time and effort into these feature for now. I'll think about it later. It would take me significant time to catch up on Android development, as my knowledge is @deprecated since I've developed the app.

tdbe commented 3 years ago

Yeah :) Same here; knowledge of android storage management is deprecated

andrasferenczi commented 2 years ago

This one is not fixed with the new version, but this is way more complicated than I expected it to be.

This can be broken down into multiple features:

tdbe commented 2 years ago

This one is not fixed with the new version, but this is way more complicated than I expected it to be.

This can be broken down into multiple features:

  • Adding custom folder which Vitrina provides to Muzei: this is technically a mix of the current Vitrina and Muzei provider
  • Favouriting artwork: I think it would be confusing to the users to have 'non-deletable favourite". After a couple tests I've found out that Muzei needs to indicate somehow which artworks are marked as 'favourite', otherwise the user would have to click through each of them. So I will approach this differently, by adding favourite mechanism as a 'mark as favourite' feature in case of logged-in Reddit account (upcoming feature) or DeviantArt. So the saving is done through the account itself and saved online.
  • Saving an image: This is done properly in the new version I think. Users can pick a folder to save the artwork.

This makes sense. Would love a hybrid folder (my wallpapers + muzei/etc). Just to be clear; if "favourite to not delete" is confusing, then can I just tell the app to not ever delete any images that it downloads and/or are in the hybrid folder? (I will instead manually delete the images I don't like)

PS: I would love to be able to have vitrina fetch my deviant art favourites and show those as wallpapers ;)

[EDIT] Oh, I guess this feature from the new app solves my "don't delete" problem: "cache limit: remove old entries if there are too many, control the disk space used by Vitrina" [EDIT] Actually, no, the new version does not help, and takes quite a lot away. I'll have to look into it myself when I have time.

andrasferenczi commented 2 years ago

Would love a hybrid folder (my wallpapers + muzei/etc)

The issue that needs to be resolved with this is when a user saves an image and it will show up as duplicate in Muzei. Once from the original source (as long as it is not removed because of cache restriction) and once because it is coming from the local folder.

can I just tell the app to not ever delete any images that it downloads and/or are in the hybrid folder?

I think that will be the goal eventually, yes. To have a folder where the images are not deleted, but only read.

I would love to be able to have vitrina fetch my deviant art favourites and show those as wallpapers ;)

I will think about this as well how to approach this. One problem to solve here is how to differentiate:

Because I am planning context-aware actions, like 'loading similar images' or 'marking current image as favourite' and only the first type will definitely have this feature.

Having a button to 'load favourites' would make sense, it is just not clear to me what will happen to those images.

Anyway, this turned out to be quite long, I am still thinking about this.

Thanks for your feedbacks and ideas @tdbe

tdbe commented 2 years ago

Cool. But just so I understand, right now, who is deleting old images from vitrina? Vitrina downloads images from somewhere, and muzei displays them. So Vitrina is deleting, not muzei, right? So can't you just add a setting in vitrina that disables deleting? Then we just delete manually.

As for the hybrid folder, duplicate images aren't a big deal. I sometimes get duplicate images just from different subreddits. I delete them manually.

andrasferenczi commented 2 years ago

Vitrina downloads images from somewhere, and muzei displays them. So Vitrina is deleting, not muzei, right?

By calling the proper Muzei API to remove the image, the image file itself is removed as well.

So can't you just add a setting in vitrina that disables deleting?

Yeah, it is doable to differentiate Reddit/DeviantArt images from gallery images, you are right.

I was just focusing too much on the Muzei context actions (gallery images would not have 'delete') and how to differentiate the artworks by their source.

tdbe commented 2 years ago

Good to know. But my question is about who is auto-deleting old images from my vitrina gallery? Does muzei have a limit and/or auto-deletes old images when new images are downloaded? I just want to disable all automatic deletion functions from my vitrina :) So if there is code in vitrina that auto-deletes files, I will just look for it and comment it out..

andrasferenczi commented 2 years ago

Vitrina. It is always Vitrina that deletes the gallery, Muzei accepts technically an infinite amount of images.

I just want to disable all automatic deletion functions from my vitrina :)

The new closed-source one does not have it enabled by default. I guess the earlier version is released with a lower max cache size, but I cannot tell for sure.