search

andrasferenczi / vitrina-legacy

A companion app for Muzei that fetches images from Reddit
24 stars 9 forks source link

Feature request: Pulling images from "All time" category in a subreddit. #24

Open fusk-l opened 2 years ago

fusk-l commented 2 years ago

While you might not know this, when Vitrina pulls images from reddit, it pulls from the "Hot" category which changes on a monthly basis. It does not pull from "All time", which means, you will not see the most highly rated pictures from that subreddit. Having a button or somthing in the settings for that subreddit where you switch between "Hot" and "All time" would be sweet.

mdkim commented 2 years ago

It looks to me like it's grabbing from the Top category:

const fetchRedditTrendingData = (sub, accessToken) =>
    fetch(`https://oauth.reddit.com/r/${sub}/top`, {

I happened to be looking at the source code today because I want the Weekly Top, not the default Top.

Is the author reading these or is it worth it for me to compile the open source version and sideload it myself with that change?

fusk-l commented 2 years ago

@mdkim I'm somewhat sure he reads these. He told me that i should create the request here so he could see if there's interest in it. While i'm sure there's interest in it, i'm unsure how many Vitrina users actually swing by github.

But if you've figured how to do "weekly top", do you also know how to do "all time"?

andrasferenczi commented 2 years ago

@mdkim I asked OP to create this issue here, just in case more people are interested in that. OP is talking about the new version and not the one that has the source code here.

The code you linked is from a JavaScript test that I created to debug why the authentication is not working properly and rule out issues on Android. This is not used in any way in the compiled application.

If anything, you may want to change this code, but AFAIK the default endpoint is the hot, so you may get better results with the existing configuration by setting up a sane min upvote count.

I don't intend to create any new releases of the old Vitrina, but feel free to modify the code for your own usage.

andrasferenczi commented 2 years ago

While i'm sure there's interest in it, i'm unsure how many Vitrina users actually swing by github.

@fusk-l Probably not too many. But there aren't too many active users either.